Created a function to get submission photo by its submission id

[Sujanadh]

Updates:

This PR updates the OdkCentral creating a new function getSubmissionPhoto to get the photo content from the individual submission.

• it taskes parameters such as odk project id, submission id(instance id) , xform(form id), filename (name of photo file)
• it fetches the media content in bytes which can be used directly to download or upload anywhere.

[spwoodcock]

It would be really nice if this included a test too 😁

But not essential if it will take lots of time 👍

[spwoodcock]

It's generally a bad idea to use eval in Python - there is almost always a better way!

Also accessing a private method is generally bad too.

Can this be achieved using .json() or another method?

[Sujanadh]

In getMedia func too eval was used, so I thought to use the same, but you are right, eval is not always a safe option. will refactor for both functions.

[Sujanadh]

It would be really nice if this included a test too 😁

But not essential if it will take lots of time 👍

how to use dummy submission photo?

[spwoodcock]

It would be really nice if this included a test too 😁

But not essential if it will take lots of time 👍

how to use dummy submission photo?

You could possibly just upload some known bytes, not an actual photo:

b'fakephotodata'

I assume uploading this with a jpg extension would work and would be lightweight (unless Central has a check to see if it's an actual image!)

Then when you check the download data, assert photo_data == b'fakephotodata'

Of course, the alternative is to include an actual (lightweight) .jpg file in the testdata!

[spwoodcock]

Tests aren't essential here, just a nice to have!

We can merge this - bump to remind myself!

[Sujanadh]

thanks for reminding!

[spwoodcock]

I'll merge this for the next release 👍

If we have tests in future, they don't need to be in a release, just present on main, so they can come later