Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated create_if and update_if column in entity sheet #307

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Sujanadh
Copy link
Contributor

Updates:

This PR introduces changes to the form logic for creating and updating entities based on a geopoint field (new_feature). The following conditions have been added:

  • Entity Creation (create_if): Entities will be created if the geopoint (new_feature) field has been captured.
    • Logic used: if(${new_feature}, true(), false())
  • Entity Update (update_if): Entities will be updated if the geopoint field has not been captured (i.e., it is empty or missing).
    • Logic used: if(${new_feature}, false(), true())

Issue:

When new feature geopoint was submitted it should have created new entity but it failed to do so. There was slight error in logic in create_if and update_if column:

  • if(${new_feature} = 'yes', true(), false()) like this, since new_feature is geopoint coordinate field comparing it directly to a string ('yes') is not valid, as the field does not return a boolean or string value but rather a set of coordinates.

@Sujanadh Sujanadh requested a review from spwoodcock October 16, 2024 04:46
@Sujanadh Sujanadh self-assigned this Oct 16, 2024
@github-actions github-actions bot added the bug Something isn't working label Oct 16, 2024
@spwoodcock spwoodcock merged commit fef4bfc into main Oct 18, 2024
5 of 6 checks passed
@spwoodcock spwoodcock deleted the fix/mandatory-form branch October 18, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants