embed video in task description/ instruction #738
Conversation
… from youtube, vimeo, etc.
|
Brilliant!! |
…showdown-youtube extension.
|
Thanks for this nice contribution! |
|
Your code looks nice. Can you please squash your commits into one? |
|
You didn't have to create a new pull request for that. You can squash/fixup commits and push force again your branch to the remote. It's worth to learn this nice feature. You'll find dedicated tutorials. |
|
Hey guys, is this live yet? I tried it on task 1460 but it didn't work, I just got a missing image type box. Thanks. |
|
Hi @aawiseman. Sorry, it's not live. I expect to do a release soon and get it on production. |
|
@pgiraud ah thanks. Do you know when roughly? Just curious. Thanks! |
|
@pgiraud hi Pierre, it still looks like it's not working, I just see a little box with a question mark. I'm looking at http://tasks.hotosm.org/project/1460 under the Instructions tab. Is the new version not live yet? Thanks! |
|
@aawiseman sorry it's still not live. The release process takes a bit of time. Hopefully, we should be able to get this working live in the next days. |
|
@pgiraud Got it, thanks! |
|
@aawiseman We finally managed to deploy the 2.12 release! It's now live. |
|
@pgiraud woohoo! Thank you, it looks great! |
for issue #721
this is to enable embedding video/image into task description/instruction by adding an oEmbed extension to python markdown library.
this solution is coming from https://github.com/rennat/python-markdown-oembed with a few bug fixes
a sample markdown for Youtube:
===== update======
also support the preview tab by updating showdown version and adding a youtube extension.
@pyrog I just noticed that PR #527 also try to update showdown version and make all markdown client rendered. if that's the case we could just add the js youtube extension in my PR and remove the python markdown extension. Do a cherrypick or just let me know after you merge #572 so I could update my PR accordingly.