Fix username fetch on every keystroke issue in commentInput component

- Fixes #6166
hotosm · Mar 18, 2024 · 117e947 · 117e947
1 parent bdadd09
commit 117e947
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/frontend/src/components/comments/commentInput.js b/frontend/src/components/comments/commentInput.js
@@ -49,9 +49,10 @@ export const CommentInputField = ({
       try {
         if (!query) return cb(contributors.map((username) => ({ username })));
 
-        // do not fetch data if the value comes from suggestions popup click
-        const isValueFromSuggestion = /^\[.*?\]\s$/.test(query);
-        if (isValueFromSuggestion) return;
+        // address trigger js allowSpaces=true issue
+        // which triggers this function every keystroke
+        const isUsernameAlreadyFetched = /^\[.*?\]\s/.test(query);
+        if (isUsernameAlreadyFetched) return;
 
         const res = await fetchLocalJSONAPI(`users/queries/filter/${query}/`, token);
         cb(res.usernames.map((username) => ({ username })));