Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rate limit to endpoints #5304

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Add rate limit to endpoints #5304

wants to merge 4 commits into from

Conversation

Aadesh-Baral
Copy link
Contributor

@Aadesh-Baral Aadesh-Baral commented Aug 14, 2022 •
edited
Loading

closes #5122
To do:

  • Add exception handling to limit exceeded exception.
  • Add redis store as rate limit storage.
  • Provision redis service
  • Decide on default rate limitng threshold

@Aadesh-Baral Aadesh-Baral force-pushed the feature/add-rate-limiter branch from d7bf376 to 6dfc126 Compare August 14, 2022 13:40
@Aadesh-Baral Aadesh-Baral force-pushed the feature/add-rate-limiter branch from 2d581ab to 57a9f7a Compare August 16, 2022 10:03
@Aadesh-Baral Aadesh-Baral force-pushed the feature/add-rate-limiter branch from c85e1eb to a2c06af Compare August 17, 2022 07:37
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ramyaragupathy
Copy link
Member

@kaditya97 @prabinoid - something to consider as part of tech debt work? cc @manjitapandey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api ⚙️ database ⛁ performance 🐎 scope: backend scope: infrastructure tech-debt 💣
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rate Limit API calls
2 participants
@Aadesh-Baral @ramyaragupathy