Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): migrate to TypeScript and Vite #6534

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

JoltCode
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • πŸ€– Build or CI

Related Issue

Fixes #6533
Fixed #6531

Describe this PR

A brief description of how this solves the issue.

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot added dependencies Pull requests that update a dependency file scope: frontend labels Aug 20, 2024
Copy link

sonarcloud bot commented Aug 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required β‰₯ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@royallsilwallz
Copy link
Contributor

hey @JoltCode, how's the progress going on with this? have you set a timeframe for this to complete?
cc - @htulipe @ramyaragupathy @manjitapandey

@JoltCode
Copy link
Collaborator Author

hey @JoltCode, how's the progress going on with this? have you set a timeframe for this to complete? cc - @htulipe @ramyaragupathy @manjitapandey

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

Feel free to shoot me a DM on Slack as well! πŸ˜„

@royallsilwallz
Copy link
Contributor

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

I think it's going to take a lot of time since it's a very strenuous task. Can you come up with a timeframe according to your availability with this PR, or we may sit on a call if you would like to discuss anything related to it?

@JoltCode
Copy link
Collaborator Author

Hey, apologies, been a bit stuck on time! I haven't, but would be more than happy to set a timeframe!

I think it's going to take a lot of time since it's a very strenuous task. Can you come up with a timeframe according to your availability with this PR, or we may sit on a call if you would like to discuss anything related to it?

Yeah it is a pretty hefty task! Sure, I'd be more than happy to call and discuss! πŸ‘

@spwoodcock
Copy link
Member

We had a call about this just now @royallsilwallz

The initial requirement to get this done quickly has passed, as we managed a workaround / fix for the PR that was dependent on this.

As this is such a big undertaking, it makes sense to subdivide into smaller PRs.

Near term goals:

  • Fix merge conflicts here.
  • Wrap up the changes in this PR.
  • Ensure all frontend tests pass and Github workflows are happy.
  • Test changes in this PR from the whole team (perhaps even community testing).

Long term goals:

  • Continue where this PR left off.
  • Make subsequent PRs upgrading JS --> TS incrementally.

@htulipe
Copy link

htulipe commented Dec 6, 2024

Let me know if I can give an hand on that

@spwoodcock
Copy link
Member

spwoodcock commented Dec 13, 2024

Thanks for the offer @htulipe !

Are you on the HOTOSM Slack by the way?
It might be easier to coordinate in a group chat πŸ™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file scope: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from JavaScript --> TypeScript Replace craco / webpack frontend module bundler with vite
4 participants