Skip to content

Commit

Permalink
Fixed: issue of label for field not updated, added entry for static t…
Browse files Browse the repository at this point in the history
…ext in locale file, and added case to store customField flag in the mappings(#269)
  • Loading branch information
ymaheshwari1 committed Sep 26, 2023
1 parent 80040b1 commit 8b73b65
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/components/CreateMappingModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,11 @@ export default defineComponent({
// removing label from mappings as we don't need to save label with the mappings as it will just increase the size of the value
Object.keys(this.fieldMapping).map((mapping) => {
mappings[mapping] = {
mappings[mapping] = this.fieldMapping[mapping].isCustomField ? {
value: this.fieldMapping[mapping].value,
isSelected: this.fieldMapping[mapping].isSelected,
isCustomField: this.fieldMapping[mapping].isCustomField
} : {
value: this.fieldMapping[mapping].value,
isSelected: this.fieldMapping[mapping].isSelected
}
Expand Down
1 change: 1 addition & 0 deletions src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@
"Select the fields you want to include in your export": "Select the fields you want to include in your export",
"Select time zone": "Select time zone",
"Select your preferred language.": "Select your preferred language.",
"Selected Fields: ": "Selected Fields: ",
"Sell inventory online": "Sell inventory online",
"Sell online": "Sell online",
"Settings": "Settings",
Expand Down
1 change: 1 addition & 0 deletions src/locales/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
"Select the fields you want to include in your export": "Selecciona los campos que deseas incluir en tu exportación",
"Select time zone": "Selecciona la zona horaria",
"Select your preferred language.": "Select your preferred language.",
"Selected Fields: ": "Selected Fields: ",
"Sell inventory online": "Sell inventory online",
"Sell online": "Sell online",
"Settings": "Configuraciones",
Expand Down
3 changes: 3 additions & 0 deletions src/views/DownloadPackedOrders.vue
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,9 @@ export default defineComponent({
if(this.selectedData[field]) {
delete this.selectedData[field]
delete this.selectedFieldMappings[field]
// change the field label to default on removing the field from the selected fields
this.fieldMapping[field] = field
} else {
this.selectedData[field] = this.fieldMapping[field]
this.selectedFieldMappings[field] = this.fieldMapping[field]
Expand Down

0 comments on commit 8b73b65

Please sign in to comment.