Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Online Store Order Limit on Online Fulfillment Card in the settings page (#241) #255

Merged
merged 18 commits into from
Oct 10, 2023

Conversation

amansinghbais
Copy link
Contributor

Related Issues

Closes #241

Short Description and Why It's Useful

Implemented an online order fulfillment limit feature in the settings page of the fulfillment app.

  • Implemented a popover for selecting between the limit such as Unlimited, No-Capacity, and Custom.
  • Implemented alerts for all the limit type such that unlimited sets the maxOrderLimit to empty null , No-capacity sets the maxOrderLimit to 0 and using custom alert having a input field we can set our own maxOrderLimit.
  • Implemented an api "getCurrentOrderCount" which fetches the total no. of orders placed today and displays that in the fulfillment card.
  • Implemented a progress bar for the custom order card in the settings page.
  • Removed the functions which toggle the "isFulffilmentTurnedOn" variable to true on false based on the toggle ,as there's no need of keeping track of it because now we are using "fulfillmentOrderLimit" for storing limit.

Screenshots of Visual Changes before/after (If There Are Any)

Before
Screenshot from 2023-08-24 10-19-09

After
Screencast from 24-08-23 10:19:52 AM IST.webm

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

src/views/orderLimitPopover.vue Outdated Show resolved Hide resolved
src/views/orderLimitPopover.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/orderLimitPopover.vue Outdated Show resolved Hide resolved
src/locales/es.json Outdated Show resolved Hide resolved
src/locales/es.json Outdated Show resolved Hide resolved
src/services/UserService.ts Outdated Show resolved Hide resolved
src/views/orderLimitPopover.vue Outdated Show resolved Hide resolved
src/locales/es.json Outdated Show resolved Hide resolved
src/views/OrderLimitPopover.vue Outdated Show resolved Hide resolved
src/views/OrderLimitPopover.vue Outdated Show resolved Hide resolved
src/views/OrderLimitPopover.vue Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
src/views/Settings.vue Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/OrderLimitPopover.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/components/OrderLimitPopover.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/components/OrderLimitPopover.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/components/OrderLimitPopover.vue Outdated Show resolved Hide resolved
src/components/OrderLimitPopover.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/components/OrderLimitPopover.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
src/views/Settings.vue Outdated Show resolved Hide resolved
@ravilodhi ravilodhi merged commit 0794027 into hotwax:main Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Store Order Limit on Online Order Fulfillment Card in the Settings Page
4 participants