Implemented: mobile view support for the inprogress page of fulfillment app (#244) #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsoK2maan
suggested changes
Aug 31, 2023
src/views/EditPackagingModal.vue
Outdated
| pricetag, | ||
| copyToClipboard, | ||
| formatUtcDate, | ||
| getFeature |
There was a problem hiding this comment.
Follow alphabetical order for exports
src/views/EditPackagingModal.vue
Outdated
| <div class="product-info"> | ||
| <ion-item lines="none"> | ||
| <ion-thumbnail slot="start"> | ||
| <img src="https://dev-resources.hotwax.io/resources/uploads/images/product/m/j/mj08-blue_main.jpg" /> | ||
| <Image :src="getProduct(item.productId).mainImageUrl" /> |
There was a problem hiding this comment.
We should use the ShopifyImage component with the image size as small.
src/views/PackagingPopover.vue
Outdated
| setup() { | ||
| return { | ||
| pencil, | ||
| warning, | ||
| refresh | ||
| refresh |
There was a problem hiding this comment.
Fix indentation and follow alphabetical sorting
src/views/ReportIssueModal.vue
Outdated
| pricetag, | ||
| copyToClipboard, | ||
| formatUtcDate, | ||
| getFeature |
… into fulfillment-pwa/hotwax#244-inprogresspage
alsoK2maan
approved these changes
Sep 18, 2023
… fulfillment-pwa/hotwax#244-inprogresspage
… fulfillment-pwa/hotwax#244-inprogresspage
|
Closing as the apps UI is getting changed and there is no immediate requirement of mobile support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related Issue: #244
Short Description and Why It's Useful
Implemented the mobile view for the inprogress page in the fulfillment app.
Screenshots of Visual Changes before/after (If There Are Any)
Before
After
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance