Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented: support to change the box type from the inProgress page(#221) #296

Merged
merged 18 commits into from
Oct 12, 2023
Merged

Implemented: support to change the box type from the inProgress page(#221) #296

merged 18 commits into from
Oct 12, 2023

Conversation

ymaheshwari1
Copy link
Contributor

Related Issues

Closes #221

Short Description and Why It's Useful

  • Go to in-progress page
  • Click on the box chip to change the type and select any value
  • Click save and verify that the box type has been changed.

Screenshots of Visual Changes before/after (If There Are Any)

After:

image

image

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

sanskar345 and others added 18 commits July 26, 2023 18:55
@sanskar345
Implemented: Ion select for box type selection
e8f3708
@sanskar345
Implemented: box type change functionalty in progress tab
a3b7778
@sanskar345
Improved: deleted unnecessary file
3387f7a
@sanskar345
Fixed: merge conflicts
dcdfb1f
@sanskar345
Implemented: chnaged boxtype to show using shipmentBoxtypeId property…
ce8b238 
… in shipment pacakges instead of 0th index of boxtypes and improved the boxtype change functionality
@sanskar345
Implemented: used ion-no-padding instead of inline style
d7a0fee
@sanskar345
Merge branch 'main' of https://github.com/hotwax/fulfillment-pwa into…
9f8f596 
… fulfillment-pwa/hotwax#221
@sanskar345
Implemented: added a check if there is no boxtype then don't show box…
c793de2 
… chip
@sanskar345
Improved: box type change function name
878d97f
@sanskar345
Implemented: logic to get shipment box types in order actions instead…
c53376f 
… of in progress view
@ymaheshwari1
Merge branch 'main' into fulfillment-pwa/hotwax#221
86fdd94
@ymaheshwari1
Improved: formatting and removed unwanted todo(hotwax#221)
35a00a5
@ymaheshwari1
Merge branch 'main' into fulfillment-pwa/hotwax#221
e34df23
@ymaheshwari1
Improved: UI to add a popover for box type and updated the logic to c…
240c052 
…hange the box type(hotwax#221)
@ymaheshwari1
Improved: form data to be passed in updateOrder api(hotwax#221)
8465b88
@ymaheshwari1
Fixed: issue of box type not being updated(hotwax#221)
ccee56a
@ymaheshwari1
Improved: support to not show box type change popover when types are …
a1dd6d0 
…not available(hotwax#221)
@ymaheshwari1
Replaced: console statement with logger(hotwax#221)
0e0d031
@ravilodhi ravilodhi merged commit ac57abd into hotwax:main Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Users to Change Box Type for In progress orders
3 participants
@ymaheshwari1 @ravilodhi @sanskar345