Implemented: logic to remove rejected order items from state manually (#638) #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravilodhi
reviewed
Nov 21, 2024
| @@ -832,6 +838,37 @@ export default defineComponent({ | |||
| logger.error('Failed to update order', err) | |||
| } | |||
| }, | |||
| removeRejectedOrder(rejectedProductIds: any, rejectedItems: any) { | |||
There was a problem hiding this comment.
I think we can take some alternate route here. On rejection we are refetching in progress orders. Rejected items won't be associated with any shipment. So if we could use that to filter out the rejected order(all items rejected) or the rejected items. This way we can keep the logic in the fetchInProgressOrdersAdditionalInformation action itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#638
Short Description and Why It's Useful
Updated code such that post item rejection, if Solr takes time to update the order data, we'll manually remove those items or orders from the state.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance