Fixed: prevented updating negative inventory counts (#207) #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanmukhdutt
changed the title
This reverts commit 466b8ce.
…ad Page(hotwax#209)" This reverts commit 1c1f41a.
…ad Page(hotwax#213)" This reverts commit 2dce920.
alsoK2maan
suggested changes
Dec 12, 2023
src/views/count.vue
Outdated
| } else { | ||
| } else if(this.quantity < 0) { | ||
| showToast(translate("Negative stock count cannot be accepted")) | ||
| }else{ |
src/locales/en.json
Outdated
| @@ -31,6 +31,7 @@ | |||
| "Logging out": "Logging out", | |||
| "Logout": "Logout", | |||
| "Make sure you've reviewed the products and their counts before uploading them for review": "Make sure you've reviewed the products and their counts before uploading them for review", | |||
| "Neagative stock count cannot be accepted":"Neagative stock count cannot be accepted", | |||
There was a problem hiding this comment.
Please recheck the spellings
| @@ -216,7 +216,7 @@ | |||
| await picker.present(); | |||
| }, | |||
| updateProductInventoryCount() { | |||
| if (this.quantity) { | |||
| if (this.quantity > 0) { | |||
There was a problem hiding this comment.
Suggested change
| if (this.quantity > 0) { | |
| if(this.quantity > 0) { |
src/locales/en.json
Outdated
| @@ -31,6 +31,7 @@ | |||
| "Logging out": "Logging out", | |||
| "Logout": "Logout", | |||
| "Make sure you've reviewed the products and their counts before uploading them for review": "Make sure you've reviewed the products and their counts before uploading them for review", | |||
| "Negative stock count cannot be accepted":"Negative stock count cannot be accepted", | |||
There was a problem hiding this comment.
Suggested change
| "Negative stock count cannot be accepted":"Negative stock count cannot be accepted", | |
| "Negative stock count cannot be accepted": "Negative stock count cannot be accepted", |
ymaheshwari1
requested changes
Dec 27, 2023
src/views/count.vue
Outdated
| @@ -216,7 +216,7 @@ | |||
| await picker.present(); | |||
| }, | |||
| updateProductInventoryCount() { | |||
| if (this.quantity) { | |||
| if(this.quantity) { | |||
There was a problem hiding this comment.
We have not handled negative check in this case, and also we have added static text entry in locale but have added the toast anywhere
shanmukhdutt
changed the title
|
Closing as having conflicts and needs improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#207
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance