Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Incorrect Toast Message Displayed When User Accepts Counted Value #473 #487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Incorrect Toast Message Displayed When User Accepts Counted Value #473 #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/views/PendingReviewDetail.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,11 +531,23 @@ async function acceptItem(item?: any) {

const resp = await Promise.allSettled(payloads.map((payload: any) => CountService.acceptItem(payload)))

const isAnyRespHasError = resp.some((response: any) => response.status === "rejected")
if(isAnyRespHasError) {
showToast(translate("Some of the item(s) are failed to accept"))
const primary = (
getProductIdentificationValue(
productStoreSettings.value.productIdentificationPref.primaryId,
getProduct.value(item.productId)
)
);
const isAnyRespHasError = resp.some(
(response: any) => response.status === "rejected"
);
if (isAnyRespHasError) {
showToast(translate("Some of the item(s) are failed to accept"));
} else {
showToast(translate("All of the item(s) are accepted"))
if (payloads.length === 1) {
showToast(translate(`Item: ${primary} has been accepted`));
} else {
showToast(translate("All items have been accepted"));
}
}
await fetchCountItems()
}
Expand Down
Loading