Skip to content

Commit

Permalink
Improved: updated the variable name for clearing current job for bett…
Browse files Browse the repository at this point in the history
…er understanding (#720)
  • Loading branch information
amansinghbais committed Nov 29, 2024
1 parent b35df66 commit 1ebfa47
Show file tree
Hide file tree
Showing 10 changed files with 20 additions and 20 deletions.
4 changes: 2 additions & 2 deletions src/views/Brokering.vue
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,8 @@ export default defineComponent({
this.getTemporalExpr(this.getJobStatus(this.jobEnums[enumId]))?.description :
translate('Disabled')
},
async fetchJobs(JobDetailDismissRequired = false) {
if(JobDetailDismissRequired) {
async fetchJobs(isCurrentJobUpdateRequired = false) {
if(isCurrentJobUpdateRequired) {
this.currentJob = "";
await this.store.dispatch('job/updateCurrentJob', { });
this.currentJobStatus = "";
Expand Down
4 changes: 2 additions & 2 deletions src/views/Fulfillment.vue
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,9 @@ export default defineComponent({
this.store.dispatch('job/updateJob', job)
}
},
async fetchJobs(JobDetailDismissRequired = false){
async fetchJobs(isCurrentJobUpdateRequired = false){
this.isLoading = true;
if(JobDetailDismissRequired) {
if(isCurrentJobUpdateRequired) {
this.currentJob = "";
await this.store.dispatch('job/updateCurrentJob', { });
this.currentJobStatus = "";
Expand Down
4 changes: 2 additions & 2 deletions src/views/InitialLoad.vue
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ export default defineComponent({
this.isJobDetailAnimationCompleted = true;
}
},
async fetchJobs(JobDetailDismissRequired = false){
if(JobDetailDismissRequired) {
async fetchJobs(isCurrentJobUpdateRequired = false){
if(isCurrentJobUpdateRequired) {
this.currentSelectedJobModal = "";
await this.store.dispatch('job/updateCurrentJob', { });
this.job = {};
Expand Down
4 changes: 2 additions & 2 deletions src/views/Inventory.vue
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ export default defineComponent({
});
this.isLoading = false
},
async fetchData(JobDetailDismissRequired = false) {
if(JobDetailDismissRequired) {
async fetchData(isCurrentJobUpdateRequired = false) {
if(isCurrentJobUpdateRequired) {
this.currentJob = "";
await this.store.dispatch('job/updateCurrentJob', { });
this.currentJobStatus = "";
Expand Down
4 changes: 2 additions & 2 deletions src/views/Miscellaneous.vue
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ export default defineComponent({
async getMiscellaneousJobs(viewSize = 100, viewIndex = 0) {
await this.store.dispatch('job/fetchMiscellaneousJobs', {eComStoreId: this.getCurrentEComStore.productStoreId, viewSize, viewIndex});
},
async updateProductStoreConfig(JobDetailDismissRequired = false) {
if(JobDetailDismissRequired) {
async updateProductStoreConfig(isCurrentJobUpdateRequired = false) {
if(isCurrentJobUpdateRequired) {
this.currentJob = "";
await this.store.dispatch('job/updateCurrentJob', { });
this.currentJobStatus = "";
Expand Down
4 changes: 2 additions & 2 deletions src/views/Orders.vue
Original file line number Diff line number Diff line change
Expand Up @@ -279,9 +279,9 @@ export default defineComponent({
this.getTemporalExpr(this.getJobStatus(this.jobEnums[enumId]))?.description :
translate('Disabled')
},
async fetchJobs(JobDetailDismissRequired = false){
async fetchJobs(isCurrentJobUpdateRequired = false){
this.isLoading = true;
if(JobDetailDismissRequired) {
if(isCurrentJobUpdateRequired) {
this.currentJob = ""
await this.store.dispatch('job/updateCurrentJob', { });
this.currentJobStatus = ""
Expand Down
4 changes: 2 additions & 2 deletions src/views/Pipeline.vue
Original file line number Diff line number Diff line change
Expand Up @@ -647,8 +647,8 @@ export default defineComponent({
this.getPendingJobs();
}
},
async updateProductStoreConfig(JobDetailDismissRequired = false) {
if(JobDetailDismissRequired) {
async updateProductStoreConfig(isCurrentJobUpdateRequired = false) {
if(isCurrentJobUpdateRequired) {
this.jobsLoading = true;
await this.store.dispatch('job/updateCurrentJob', { job: {} });
this.currentJobStatus = ""
Expand Down
4 changes: 2 additions & 2 deletions src/views/PreOrder.vue
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ export default defineComponent({
}
});
},
async fetchInitialData(JobDetailDismissRequired = false) {
if(JobDetailDismissRequired) {
async fetchInitialData(isCurrentJobUpdateRequired = false) {
if(isCurrentJobUpdateRequired) {
this.currentJob = "";
await this.store.dispatch('job/updateCurrentJob', { });
this.currentJobStatus = ""
Expand Down
4 changes: 2 additions & 2 deletions src/views/Product.vue
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,9 @@ export default defineComponent({
this.getTemporalExpr(this.getJobStatus(this.jobEnums[enumId]))?.description :
translate('Disabled')
},
async fetchJobs(JobDetailDismissRequired = false){
async fetchJobs(isCurrentJobUpdateRequired = false){
this.isLoading = true;
if(JobDetailDismissRequired) {
if(isCurrentJobUpdateRequired) {
this.currentJob = ""
await this.store.dispatch('job/updateCurrentJob', { });
this.currentJobStatus = ""
Expand Down
4 changes: 2 additions & 2 deletions src/views/Reports.vue
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,8 @@ export default defineComponent({
async getReportsJobs(viewSize = 200, viewIndex = 0) {
await this.store.dispatch('job/fetchReportsJobs', { eComStoreId: this.getCurrentEComStore.productStoreId, viewSize, viewIndex });
},
async updateProductStoreConfig(JobDetailDismissRequired = false) {
if(JobDetailDismissRequired) {
async updateProductStoreConfig(isCurrentJobUpdateRequired = false) {
if(isCurrentJobUpdateRequired) {
this.currentJob = "";
await this.store.dispatch('job/updateCurrentJob', { });
this.currentJobStatus = "";
Expand Down

0 comments on commit 1ebfa47

Please sign in to comment.