Added a view entity for customer feed. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt2patel
requested changes
Dec 31, 2024
entity/NetsuiteCustomer.xml
Outdated
| <member-entity entity-alias="PID" entity-name="org.apache.ofbiz.party.party.PartyIdentification" join-from-alias="PTY"> | ||
| <key-map field-name="partyId"/> | ||
| <entity-condition> | ||
| <econdition field-name="partyIdentificationTypeId" operator="equals" value="SHOPIFY_CUST_ID"/> |
There was a problem hiding this comment.
we need a way to make the party identification included in the feed a selectable parameter or this should go in the groovy script. I think partyIdentificationTypes should be a list that can be passed into the main service. Then we can have a wrapper specifically for syncing Shopify customers to NS.
entity/NetsuiteCustomer.xml
Outdated
| <member-entity entity-alias="PCONTECH" entity-name="org.apache.ofbiz.party.contact.PartyContactMech" join-from-alias="PTY" join-optional="true"> | ||
| <key-map field-name="partyId"/> | ||
| <entity-condition> | ||
| <date-filter/> |
There was a problem hiding this comment.
why do we have a date filter here?
There was a problem hiding this comment.
The date filter is need to fetch the valid contact mech in case we have two or more records in the associated with same party with from date and thru date set on it.
we generally add the date filter on those entity where we have the from date and thru date fields.
…nector into customer-feed-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: added description