Added a service to generate the customer feed from hotwax to Netsuite. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixitdeepak
reviewed
Dec 30, 2024
| customerData.remove("areaCode") | ||
| customerData.remove("contactNumber") | ||
|
|
||
| customerList.add(customerData) |
There was a problem hiding this comment.
It's not good practice to keep all data in memory and then write to file. This will cause performance issue,
Instead you should write data to file.
There was a problem hiding this comment.
So as each customer is iterated, we should be writing to file. Correct? @dixitdeepak
There was a problem hiding this comment.
We should use writer to write data for each row, there are various ways to write large data in file using writer stream.
dt2patel
requested changes
Dec 31, 2024
| productStoreId:productStoreId], false)"/> | ||
| <set field="csvFilePath" from="ec.resource.getLocationReference(csvFilePathRef).getUri().getPath()"/> | ||
|
|
||
| <!--TODO: Here currently the view used to get the eligible orders for the create feed does not have the shipment method |
| customerData.remove("areaCode") | ||
| customerData.remove("contactNumber") | ||
|
|
||
| customerList.add(customerData) |
There was a problem hiding this comment.
So as each customer is iterated, we should be writing to file. Correct? @dixitdeepak
| } | ||
| } | ||
| </script> | ||
| <!-- Save the Json Feed File path in System Message messageText --> |
There was a problem hiding this comment.
Suggested change
| <!-- Save the Json Feed File path in System Message messageText --> | |
| <!-- Save the CSV Feed File path in System Message messageText --> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: Add the description