Refactor system message type parameter entity #70

Nishtha-Jain-1119 · 2024-03-21T06:37:50Z

Created a new EnumType called "SystemMessageTypeParameter" and an associated Enumeration for all parameterNames.
For systemMessageTypeId created an Enumeration of type "ShopifyMessageTypeEnum", if doesn't exist already.
Associated parameters to ShopifyMessageTypeEnum through EnumGroupMember entity.
Changed primary key of SystemMessageTypeParameter entity.
Added data in ShopifyConfigDemoData.xml
Added UpgradeData_upcoming.xml with new changes.

mridulpathak · 2024-03-21T09:54:15Z

data/ShopifySetupSeedData.xml

    <!-- Parent SystemMessageType record for incoming and outgoing local feed file system message types -->
    <moqui.service.message.SystemMessageType systemMessageTypeId="LocalFeedFile" description="Local Feed File"/>
-
+    <moqui.basic.Enumeration description="Local Feed File" enumId="LocalFeedFile" enumTypeId="ShopifyMessageTypeEnum"/>


Don't need enum for this, it's a ParentType to other system messages.

mridulpathak · 2024-03-21T09:54:22Z

data/ShopifySetupSeedData.xml

    <!-- Parent SystemMessageType for all the shopify bulk import mutation system message types -->
    <moqui.service.message.SystemMessageType systemMessageTypeId="ShopifyBulkImport" description="Parent SystemMessageType for Shopify Bulk Imports"/>
+    <moqui.basic.Enumeration description="Parent SystemMessageType for Shopify Bulk Imports" enumId="ShopifyBulkImport" enumTypeId="ShopifyMessageTypeEnum"/>


Don't need enum for this, it's a ParentType to other system messages.

mridulpathak · 2024-03-21T09:54:28Z

data/ShopifySetupSeedData.xml


    <!-- Parent SystemMessageType for all the shopify bulk query system message types -->
    <moqui.service.message.SystemMessageType systemMessageTypeId="ShopifyBulkQuery" description="Parent SystemMessageType for Shopify Bulk Query"/>
+    <moqui.basic.Enumeration description="Parent SystemMessageType for Shopify Bulk Query" enumId="ShopifyBulkQuery" enumTypeId="ShopifyMessageTypeEnum"/>


Don't need enum for this, it's a ParentType to other system messages.

mridulpathak · 2024-03-21T09:55:46Z

data/ShopifySetupSeedData.xml

@@ -72,7 +110,7 @@ under the License.
            receiveResponseEnumId="MsgRrMove"
            receiveMovePath=""
            sendPath="${contentRoot}/shopify/ProductTagsFeed">
-        <parameters parameterName="consumeSmrId" parameterValue="" systemMessageRemoteId=""/>
+


Seems to be an extra line.

mridulpathak · 2024-03-21T09:58:04Z

data/ShopifySetupSeedData.xml

+    <moqui.basic.Enumeration enumId="namespaces" enumTypeId="SystemMessageTypeParameter"/>
+
+    <!-- EnumerationGroupMember data for system message type and system message parameter -->
+    <moqui.basic.EnumGroupMember enumGroupEnumId="OMSFulfillmentFeed" enumId="consumeSmrId" sequenceNum="1"/>


Move each of these EnumGroupRecords with respective SystemMessageType and Enumeration records.

mridulpathak · 2024-03-27T11:43:13Z

data/UpgradeData_Upcoming.xml

 <entity-facade-xml type="ext-upgrade-upcoming">
+    <!-- EnumerationType for Shopify system message type enum and relationship -->
+    <moqui.basic.Enumeration description="Local Feed File" enumId="LocalFeedFile" enumTypeId="ShopifyMessageTypeEnum"/>


We don't need Enumeration for parent SystemMessageType(s).

mridulpathak · 2024-03-27T11:44:02Z

data/UpgradeData_Upcoming.xml

@@ -9,7 +52,7 @@
            sendPath="component://shopify-connector/template/graphQL/BulkOrderDiscountCodeApplQuery.ftl"
            consumeServiceName="co.hotwax.shopify.system.ShopifySystemMessageServices.consume#BulkOperationResult"
            receivePath="${contentRoot}/shopify/BulkOrderDiscountCodeAppl/BulkOperationResult-${systemMessageId}-${remoteMessageId}-${nowDate}.jsonl">
-        <parameters parameterName="consumeSmrId" parameterValue="" systemMessageRemoteId=""/>
+<!--         <parameters parameterName="consumeSmrId" parameterValue="" systemMessageRemoteId=""/> -->


We could remove this parameter here as we have added it in demo data.

data/ShopifySetupSeedData.xml

mridulpathak · 2024-04-01T09:07:16Z

upgrade/v1.3.3/UpgradeData_Upcoming.md

+## Steps for migration of Database
+#### To make SYSTEM_MESSAGE_REMOTE_ID a part of the Primary key of SystemMessageTypeParameter entity.
+
+1. Stop the server


Remove this step.

mridulpathak · 2024-04-01T09:07:30Z

upgrade/v1.3.3/UpgradeData_Upcoming.md

+```sql
+desc SYSTEM_MESSAGE_TYPE_PARAMETER;
+```
+5.  Restart the server.


Remove this step.

mridulpathak · 2024-04-01T09:08:48Z

upgrade/v1.3.3/UpgradeData_Upcoming.md

@@ -0,0 +1,22 @@
+## Steps for migration of Database
+#### To make SYSTEM_MESSAGE_REMOTE_ID a part of the Primary key of SystemMessageTypeParameter entity.


Add following "Perform following migration steps before upgrading,"

mridulpathak · 2024-04-01T09:10:05Z

upgrade/v1.3.3/UpgradeData_Upcoming.md

Change the file name to UpgradeSteps_Upcoming.md
No need to add v1.3.3 directory at this point, move the file to root "upgrade" directory.

…pgradeSteps_Upcoming.md

data/ShopifyConfigDemoData.xml

mridulpathak · 2024-04-22T06:24:55Z

upgrade/UpgradeSteps_Upcoming.md

We should rename and move file to upgrade/upcoming/UpgradeSteps.md to follow the pattern.

…://github.com/Nishtha-Jain-1119/mantle-shopify-connector into refactor-system_message_type_parameter-entity

Nishtha-Jain-1119 added 7 commits March 20, 2024 11:16

enumeration data for system message type parameter

412dc8c

Enumeration data for system message type

7c9e0c7

EnumGroupMember data

a5c894d

added shopify config data

1a9498b

Enumeration data for shooify message type

4f70785

System Mesage RemoteId as primary key

8df8f16

Created UpgradeData_upcoming.xml file

7d14f40

Nishtha-Jain-1119 requested a review from mridulpathak March 21, 2024 06:38

mridulpathak reviewed Mar 21, 2024

View reviewed changes

Nishtha-Jain-1119 and others added 6 commits March 21, 2024 16:51

Removed enum from parent type system message

de8a44b

Moved EnumGroup record with their SystemMessageType

1d58f60

renamed UpgradeData_Upcoming.xml

d516538

Resolved merge conflicts

ffcab42

Update ShopifyConfigDemoData.xml

366c214

resolve conflicts

24e1edb

mridulpathak reviewed Mar 27, 2024

View reviewed changes

data/ShopifySetupSeedData.xml Show resolved Hide resolved

Nishtha-Jain-1119 and others added 6 commits March 28, 2024 11:09

Update UpgradeData_Upcoming.xml

69f4b1e

removed BulkOperationsFinish systemMessageTypeId

223f911

Update ShopifySetupSeedData.xml

99063b7

added enum data

0f1fee1

Update README.md

d865827

addad UpgradeData_Upcoming file for v1.3.3

9f81ad3

mridulpathak reviewed Apr 1, 2024

View reviewed changes

Nishtha-Jain-1119 and others added 5 commits April 1, 2024 14:40

Update README.md

c6c2b6a

updated UpgradeSteps_Upcoming file

55be3ba

Update and rename upgrade/v1.3.3/UpgradeData_Upcoming.md to upgrade/U…

cec68fb

…pgradeSteps_Upcoming.md

updated Readme.md

f3bb5de

update UpgradeSteps_Upcoming

32af184

mridulpathak reviewed Apr 3, 2024

View reviewed changes

data/ShopifyConfigDemoData.xml Show resolved Hide resolved

mridulpathak reviewed Apr 22, 2024

View reviewed changes

Nishtha-Jain-1119 and others added 4 commits April 22, 2024 12:13

Update ShopifyConfigDemoData.xml

dbacc87

Merge branch 'refactor-system_message_type_parameter-entity' of https…

d958537

…://github.com/Nishtha-Jain-1119/mantle-shopify-connector into refactor-system_message_type_parameter-entity

moved UpgradeSteps.md to upcoming folder

b51c596

resolved conflicts while merging develop

fb03a53

dixitdeepak changed the base branch from develop to main December 16, 2024 13:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor system message type parameter entity #70

Refactor system message type parameter entity #70

Nishtha-Jain-1119 commented Mar 21, 2024

mridulpathak Mar 21, 2024

mridulpathak Mar 21, 2024

mridulpathak Mar 21, 2024

mridulpathak Mar 21, 2024

mridulpathak Mar 21, 2024

mridulpathak Mar 27, 2024

mridulpathak Mar 27, 2024

mridulpathak Apr 1, 2024

mridulpathak Apr 1, 2024

mridulpathak Apr 1, 2024

mridulpathak Apr 1, 2024

mridulpathak Apr 22, 2024

		@@ -0,0 +1,22 @@
		## Steps for migration of Database
		#### To make SYSTEM_MESSAGE_REMOTE_ID a part of the Primary key of SystemMessageTypeParameter entity.

Refactor system message type parameter entity #70

Are you sure you want to change the base?

Refactor system message type parameter entity #70

Conversation

Nishtha-Jain-1119 commented Mar 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment