Improved:Updated the oms-api package to resolve login issues encountered when /api is omitted from the complete URL. Additionally, implemented a check in the app to handle direct URL access. #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Sourabh
added a commit
to R-Sourabh/preorder
that referenced
this pull request
Mar 21, 2024
R-Sourabh
added a commit
to R-Sourabh/preorder
that referenced
this pull request
Mar 22, 2024
ymaheshwari1
approved these changes
Apr 3, 2024
R-Sourabh
added a commit
to R-Sourabh/preorder
that referenced
this pull request
Apr 5, 2024
R-Sourabh
added a commit
to R-Sourabh/preorder
that referenced
this pull request
Apr 9, 2024
R-Sourabh
added a commit
to R-Sourabh/preorder
that referenced
this pull request
Apr 9, 2024
R-Sourabh
added a commit
to R-Sourabh/preorder
that referenced
this pull request
Jul 9, 2024
R-Sourabh
added a commit
to R-Sourabh/preorder
that referenced
this pull request
Jul 9, 2024
R-Sourabh
added a commit
to R-Sourabh/preorder
that referenced
this pull request
Nov 19, 2024
R-Sourabh
added a commit
to R-Sourabh/preorder
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
hotwax/dxp-components#272
Short Description and Why It's Useful
Improved: login issue in app when /api is not passed with oms complete url by updating the oms-api package and adding a check when accessing url directly in the app. Updated the oms-api version.
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance