-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handleWarning on undefined controller or action #653
Draft
AndersGM
wants to merge
24
commits into
hotwired:main
Choose a base branch
from
AndersGM:warn-on-missing-identifier
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersGM
force-pushed
the
warn-on-missing-identifier
branch
2 times, most recently
from
February 8, 2023 17:56
b565eb7
to
312344d
Compare
AndersGM
force-pushed
the
warn-on-missing-identifier
branch
from
February 8, 2023 18:12
312344d
to
6ededb8
Compare
AndersGM
force-pushed
the
warn-on-missing-identifier
branch
from
June 16, 2023 09:25
981b58f
to
3a6e261
Compare
something that works
reverted change
AndersGM
force-pushed
the
warn-on-missing-identifier
branch
from
June 16, 2023 09:42
a73ac9a
to
e43fdc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Stimulus to emit warnings if a controller or an action is non-existent.
Reintroduces parts of #413 with focus on action and controller and handling the issues mentioned in the comments.