Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support broadcast_remove_to with options #642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shuynh3
Copy link

@shuynh3 shuynh3 commented Jul 2, 2024

Make broadcast_remove_to behavior consistent with other broadcast_*_to methods by allowing keyword arguments to be passed down to broadcast_action_to.

The main use case is supporting multiple targets for broadcast_remove_to like other methods do.
i.e.: broadcast_remove_to *streamables, target: nil, targets: '.css-class-name'

Options are supported by the method called downstream:
broadcastable.rb
image
broadcasts.rb
image

Here are some existing examples of other broadcast_*_to methods following similar patterns to the change made:

broadcast_update_to:
image

broadcast_replace_to:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant