Upgrade all packages #551
Upgrade all packages #551
Conversation
We only have devDeps so no need to check them
|
The tests are failing because GitHub Actions runners use Chrome 98 right now (https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md#browsers-and-drivers). They also come with ChromeDriver which works with 98. It should be possible to set an environment flag to get |
|
Could we lock intern to a version that has the prebaked 98 for now? |
keithamus
force-pushed
the
upgrade-all-packages
branch
4 times, most recently
from
f7e67da
to
c637fb2
Compare
Pins Intern chromedriver to the one available in actions Refs theintern/intern#1159 Co-authored-by: Kristján Oddsson <[email protected]>
keithamus
force-pushed
the
upgrade-all-packages
branch
from
c637fb2
to
b1cbe12
Compare
| CHROMEVER="$(chromedriver --version | cut -d' ' -f2)" | ||
| echo "Actions ChromeDriver is $CHROMEVER" | ||
| CONTENTS="$(jq '.tunnelOptions.drivers[0].name = "chrome"' < intern.json)" | ||
| CONTENTS="$(echo ${CONTENTS} | jq --arg chromever "$CHROMEVER" '.tunnelOptions.drivers[0].version = $chromever')" | ||
| echo "${CONTENTS}" > intern.json | ||
| cat intern.json | ||
|
|
There was a problem hiding this comment.
This script uses the actions environment to determine the correct Chrome version, and writes into Intern.json the version to use. I think intern still downloads it's own copy of ChromeDriver, but at least it gets the tests running 😂
This upgrades known dependencies to their latest versions, and makes a few small changes to the
tsconfigandfetch_requestfiles to upgrade the failing TypeScript build.