Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove smc references in footers #800

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

ludtkemorgan
Copy link
Collaborator

This PR addresses bloom-housing#4456

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This removes the links to SMC site on both Alameda and San Jose

How Can This Be Tested/Reviewed?

  • Start up public site with jurisdiction set to Alameda
    • No link to SMC should be on the footer
  • Start up public site with jurisdiction set to San Jose
    • No link to SMC should be on the footer

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 818ac63
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/672b8b80ea4c100008d3abcb
😎 Deploy Preview https://deploy-preview-800--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ludtkemorgan ludtkemorgan merged commit a71c126 into main Nov 7, 2024
37 checks passed
@ludtkemorgan ludtkemorgan deleted the 4456/smc-removal branch November 7, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants