[Jormungandr] Harmonize multilanguage parameters in navitia

[kadhikari]

The followings are some details:

• Only one parameter language should be used instead of three existing parameters.
• Use of 11 languages allowed in navitia but all languages are not used in each street_network connector.
• In navitia, use of wrong value raises error with a message = Select a specific language for street network instructions ...
• if no language is provided in request, using the value configured in the coverage (default value for coverage = fr-FR)
• then if the language chosen in navitia is absent in a street_network connector, en-US will be used.
• never supposed to happen, but to avoid crash: in all connectors final fallback is to fr-FR

Note: The existing attribute asgard_language should be deleted once the next release is deployed to all the platforms.

For more details: https://navitia.atlassian.net/browse/NAV-2152

[SGrenet]

need navitia-configurator PR too to change asgard_language to language
https://github.com/hove-io/navitia-configurator/blob/fbf8cb3e8b3e0691a03b122c1cdc5fd75c099642/coverages.py#L86

and how to switch ? hard manual sync or smooth with retro-compatibility?

[kadhikari]

need navitia-configurator PR too to change asgard_language to language https://github.com/hove-io/navitia-configurator/blob/fbf8cb3e8b3e0691a03b122c1cdc5fd75c099642/coverages.py#L86

and how to switch ? hard manual sync or smooth with retro-compatibility?

The new parameter language in navitia as well as attribute in the database has a default value 'french'.
we don't need to modify in navitia-configurator for the existing configuration asgard_language: str = "french"
Will have to update la config after deploying navitia with future release.

[jthiard]

As stated in another comment, this "en-EN" language tag was a documentation error on our side (Handimap).
You can safely replace it with a more conventional en-US without any risk (en-US is our default, and already used used as fallback for any unknown language tag like en-EN).
Sorry for that documentation fail.

[kadhikari]

As stated in another comment, this "en-EN" language tag was a documentation error on our side (Handimap). You can safely replace it with a more conventional en-US without any risk (en-US is our default, and already used used as fallback for any unknown language tag like en-EN). Sorry for that documentation fail.

Hi @jthiard will it be possible to put the link of the DOC Hadimap as I don't have other than https://dev.keolis-rennes.handimap.fr/docs/ and it give mes [ fr-FR, en-EN ] as language ?
Thanks

[jthiard]

Hi @kadhikari sure, we have two urls :

• https://dev.keolis-rennes.handimap.fr/docs/ : our staging instance
• https://keolis-rennes.handimap.fr/docs/ our prod instance

At this time the two use the same version since there is no future version in staging yet.

If you still see en-EN on https://dev.keolis-rennes.handimap.fr/docs/ it may be your browser cache. You can try https://keolis-rennes.handimap.fr/docs/ which may be not cached on your side.

I just changed the webserver config to send "no cache" headers for our openAPI file to avoid this cache problem in the future.

[pbougue]

Same for https://github.com/hove-io/navitia/pull/4084/files#diff-1db49300dbe77e5d5ef58deb0ebd54793fd7851c5f9a3b238ebd4091567bf5caR133 and https://github.com/hove-io/navitia/pull/4084/files#diff-3307dc8a614b49809e0d0843ff12386f70537d2f093790b1d2872d6fd89ab70eR352:
Here you don't "respect" the default value of the coverage, no?
I think you should default to None and have asgard-connector deal with the default(coverage) value in a single place.

[kadhikari]

It's nearly impossible to have language = None, and it arrives default language in navitia before using connector street_network will be fr-FR
Since instance is absent here, no way to get instance.language !

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

68.4% Coverage
0.0% Duplication

The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here