fix data race in TestLedgerBufferClose

howardtw · May 7, 2024 · 241c802 · 241c802
1 parent 010e254
commit 241c802
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/ingest/ledgerbackend/buffered_storage_backend_test.go b/ingest/ledgerbackend/buffered_storage_backend_test.go
@@ -441,16 +441,20 @@ func TestLedgerBufferClose(t *testing.T) {
 	partition := ledgerPerFileCount*partitionSize - 1
 
 	objectName := fmt.Sprintf("0-%d/%d.xdr.gz", partition, 3)
+	afterPrepareRange := make(chan struct{})
 	mockDataStore.On("GetFile", mock.Anything, objectName).Return(io.NopCloser(&bytes.Buffer{}), context.Canceled).Run(func(args mock.Arguments) {
+		<-afterPrepareRange
 		go bsb.ledgerBuffer.close()
 	}).Once()
+
 	t.Cleanup(func() {
 		mockDataStore.AssertExpectations(t)
 	})
 
 	bsb.dataStore = mockDataStore
 
 	assert.NoError(t, bsb.PrepareRange(ctx, ledgerRange))
+	close(afterPrepareRange)
 
 	bsb.ledgerBuffer.wg.Wait()