Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17630 & 17861: Implements number interning, improves change value efficiency, fixes cyclic bug #25

Merged
merged 51 commits into from
Oct 27, 2023
Merged

17630 & 17861: Implements number interning, improves change value efficiency, fixes cyclic bug #25

merged 51 commits into from
Oct 27, 2023

Conversation

howsohazard
Copy link
Contributor

No description provided.

@howsohazard
17630: Lays groundwork data structure to allow for number value inter…
8c4d1b9 
…ning
@howsohazard
17630: More progress in implementation and renames
eefe906
@howsohazard
17630: Implements two number interning methods
f5fed11
@howsohazard
17630: More progress
7881d8f
@howsohazard
17630: Minor reorganization
f166474
@howsohazard
17630: More progress, more todos
7c79ebf
@howsohazard
17630: Handles string interning deletes
cbb39d7
@howsohazard
17630: Improves intern value management
f68390e
@howsohazard
17630: Adds feature difference typess for interned numbers
06a7bf8
@howsohazard
17630: More progress
1b7ae3e
@howsohazard
17630: More updates
d314260
@howsohazard
17630: Nears completion of initial implementation
f994051
@howsohazard
17630: More progress, more to do
39e05d9
@howsohazard
17630: More progress, but may have a bug with cyclics
bfeafcf
@howsohazard
17630: More fixes
905fbfe
@howsohazard
17630: More cleanup, at least one bug lingering before the last bits …
f3e8df7 
…can be implemented
@howsohazard
17630: Restructuring, needs to be finished to work
74712bb
@howsohazard
17630: More progress but bugs
7748831
@howsohazard
17630: Some possible minor cleanup, but notable bugs remain
50b2b23
@howsohazard
17630: Heuristic fix
d9b800b
@howsohazard
17630: Fixes some bugs
218992f
@howsohazard
17630: Adds debug code
bd211c0
@howsohazard
17630: Fixes bugs and improves naming of some methods in distance
0d7283e
@howsohazard
17630: Removes forced interning
0649269
@howsohazard
17630: Fixes bugs around changing values in sbfds
4084786
@howsohazard
17630: Renames precomputed distance terms
70f17d5
@howsohazard
17630: Reorganizing and performance improvements
42a65af
@howsohazard
17630: Changes order of universally numeric vs precomputed branching
d69fb59
@howsohazard
17630: Tightened inner loop
0d6fbdd
@howsohazard
17630: More cleanup and performance tweaks
77f1229
@howsohazard howsohazard requested a review from a team as a code owner October 23, 2023 22:34
@howsohazard howsohazard merged commit d08b199 into main Oct 27, 2023
17 checks passed
@howsohazard howsohazard deleted the 17861-change-value-efficiency branch October 27, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cademack cademack cademack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howsohazard @cademack @howsoRes