fix series

howso/client/pandas/client.py

@@ -229,15 +229,9 @@ def react_series(
         """
         trainee_id = self._resolve_trainee_id(trainee_id)
         feature_attributes = self.trainee_cache.get(trainee_id).features
-        response = super().react_series(trainee_id, *args, **kwargs)
+        response = super().react_series(trainee_id, series_index, *args, **kwargs)
 
-        # If series_index is not a string, the intention is likely for it to not be included
-        if not isinstance(series_index, str):
-            series_index = None
-
-        # Build response DataFrame
-        df = build_react_series_df(response, series_index=series_index)
-        response['series'] = format_dataframe(df, feature_attributes)
+        response['series'] = format_dataframe(response.get("series"), feature_attributes)
 
         return response
 

howso/direct/client.py

@@ -47,6 +47,7 @@
     TraineeVersion
 )
 from howso.utilities import (
+    build_react_series_df,
     internals,
     num_list_dimensions,
     ProgressTimer,
@@ -1917,6 +1918,7 @@ def react_series(  # noqa: C901
         series_context_features: Optional[Iterable[str]] = None,
         series_context_values: Optional[Union[List[object], List[List[object]]]] = None,
         series_id_tracking: Literal["dynamic", "fixed", "no"] = "fixed",
+        series_index: Optional[str] = None,
         series_stop_maps: Optional[List[Dict[str, Dict]]] = None,
         substitute_output: bool = True,
         suppress_warning: bool = False,
@@ -2035,7 +2037,10 @@ def react_series(  # noqa: C901
               allowed to change the series ID that it tracks based on its
               current context.
             - If "no", does not track any particular series ID.
-
+        series_index : str, Optional
+            When set to a string, will include the series index as a
+            column in the returned DataFrame using the column name given.
+            If set to None, no column will be added.
         progress_callback : callable, optional
             A callback method that will be called before each
             batched call to react series and at the end of reacting. The method
@@ -2359,7 +2364,9 @@ def react_series(  # noqa: C901
                 suppress_warning=suppress_warning
             )
 
-        response = CasesWithDetails(response.get('series'), response.get('explanation'))
+        series_df = build_react_series_df(response, series_index=series_index)
+
+        response = CasesWithDetails(series_df, response.get('explanation'))
 
         return response
 

howso/utilities/reaction.py

@@ -68,14 +68,16 @@ def __init__(self,
                  details: t.Optional[t.MutableMapping[str, t.Any]] = None
                  ):
         """Initialize the dictionary with the allowed keys."""
-
         self._data = {
             'action': None,
             'details': {}
         }
 
-        if action:
-            self.add_reaction(action, details or {})
+        if details is None:
+            details = {}
+
+        if action is not None:
+            self.add_reaction(action, details)
         elif details:
             self._data['details'] = details