Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

19162: Removes trainee version file tracking, MAJOR #121

Merged
merged 19 commits into from
Feb 22, 2024
Merged

19162: Removes trainee version file tracking, MAJOR #121

merged 19 commits into from
Feb 22, 2024

Conversation

calebwherry
Copy link
Contributor

No description provided.

@calebwherry calebwherry changed the title 19162: Removes trainee version file tracking 19162: Removes trainee version file tracking, MAJOR Feb 1, 2024
@calebwherry calebwherry marked this pull request as ready for review February 16, 2024 01:15
@calebwherry calebwherry requested a review from a team as a code owner February 16, 2024 01:15
mkoistinen
mkoistinen previously approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@mkoistinen mkoistinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving (nice work!) but I have some questions. Can we not warn about wrong versions rather than raise? I feel like, as developers, we may stitch ourselves up otherwise.

howso/direct/core.py Outdated Show resolved Hide resolved
howso/direct/core.py Outdated Show resolved Hide resolved
cademack
cademack previously approved these changes Feb 22, 2024
View reviewed changes
cademack
cademack previously approved these changes Feb 22, 2024
View reviewed changes
@calebwherry calebwherry merged commit 2a924e1 into main Feb 22, 2024
32 checks passed
@calebwherry calebwherry deleted the 19162-add-loadentity-status branch February 22, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cademack cademack cademack approved these changes

@mkoistinen mkoistinen mkoistinen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebwherry @mkoistinen @cademack