Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21860: Improved type hinting #309

Merged
merged 2 commits into from
Oct 16, 2024
Merged

21860: Improved type hinting #309

merged 2 commits into from
Oct 16, 2024

Conversation

fulpm
Copy link
Member

@fulpm fulpm commented Oct 15, 2024

  • Updates modules to bring them up to the latest typing standards
  • Fixes feature conviction in the scikit package

@fulpm fulpm requested a review from a team as a code owner October 15, 2024 21:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Test Results

471 tests  ±0   455 ✅ ±0   1m 3s ⏱️ -3s
  1 suites ±0    16 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit d82e736. ± Comparison against base commit 81e4a4c.

♻️ This comment has been updated with latest results.

@fulpm fulpm merged commit 5652362 into main Oct 16, 2024
40 checks passed
@fulpm fulpm deleted the 21860-improve-typehints branch October 16, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cademack cademack cademack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fulpm @cademack