Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21718: IFA reports 'allow_null': True for all-null columns #312

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

dmaze
Copy link
Contributor

@dmaze dmaze commented Oct 18, 2024

No description provided.

@dmaze dmaze requested a review from a team as a code owner October 18, 2024 15:24
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Test Results

490 tests  +1   474 ✅ +2   1m 6s ⏱️ -35s
  1 suites ±0    16 💤  - 1 
  1 files   ±0     0 ❌ ±0 

Results for commit f2b6d82. ± Comparison against base commit 580088d.

This pull request removes 6 and adds 7 tests. Note that renamed tests count towards both.
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[None-data14-expected_bounds14]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[None-data19-expected_bounds19]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[None-data9-expected_bounds9]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[tight_bounds13-data13-expected_bounds13]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[tight_bounds18-data18-expected_bounds18]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[tight_bounds6-data6-expected_bounds6]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[None-data13-expected_bounds13]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[None-data18-expected_bounds18]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[None-data20-expected_bounds20]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[None-data6-expected_bounds6]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[tight_bounds14-data14-expected_bounds14]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[tight_bounds19-data19-expected_bounds19]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_infer_feature_bounds[tight_bounds9-data9-expected_bounds9]
This pull request skips 2 and un-skips 3 tests.
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_get_feature_type_raises[123-float128]
howso.utilities.tests.test_features ‑ test_feature_deserialization_number_conversions[data15-float128-original_type15]
howso.utilities.tests.test_utilities ‑ test_locale_override[fr_FR-None-5-mar. 13 oct. 2020 17:02:27]
howso.utilities.tests.test_utilities ‑ test_locale_override[fr_FR-utf-8-0-mar. 13 oct. 2020 17:02:27]
howso.utilities.tests.test_utilities ‑ test_locale_override[fr_FR.crazy_encoding_designation-utf-8-5-mar. 13 oct. 2020 17:02:27]

♻️ This comment has been updated with latest results.

@dmaze dmaze merged commit 91cc2a6 into main Oct 18, 2024
40 checks passed
@dmaze dmaze deleted the 21718-ifa-all-nulls branch October 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants