Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21832: Expands IFA unit tests for types around edge cases #321

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

apbassett
Copy link
Member

@apbassett apbassett commented Nov 5, 2024

Adds unit tests to ensure that IFA can handle feature names that are the same as base feature types (i.e., nominal, ordinal, continuous).

@apbassett apbassett requested a review from a team as a code owner November 5, 2024 15:12
@apbassett apbassett enabled auto-merge (squash) November 5, 2024 15:12
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Results

509 tests  +4   492 ✅ +3   1m 45s ⏱️ +33s
  1 suites ±0    17 💤 +1 
  1 files   ±0     0 ❌ ±0 

Results for commit 7cf8f42. ± Comparison against base commit b8fe3b1.

This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both.
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_preset_feature_types[data4-types4-expected_types4-False]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_preset_feature_types[data5-types5-expected_types5-False]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_preset_feature_types[data4-types4-expected_types4-True]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_preset_feature_types[data5-types5-expected_types5-True]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_preset_feature_types[data6-types6-expected_types6-True]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_preset_feature_types[data7-types7-expected_types7-True]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_preset_feature_types[data8-types8-expected_types8-False]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_preset_feature_types[data9-types9-expected_types9-False]
This pull request skips 3 and un-skips 2 tests.
howso.utilities.tests.test_utilities ‑ test_locale_override[fr_FR-None-5-mar. 13 oct. 2020 17:02:27]
howso.utilities.tests.test_utilities ‑ test_locale_override[fr_FR-utf-8-0-mar. 13 oct. 2020 17:02:27]
howso.utilities.tests.test_utilities ‑ test_locale_override[fr_FR.crazy_encoding_designation-utf-8-5-mar. 13 oct. 2020 17:02:27]
howso.utilities.feature_attributes.tests.test_infer_feature_attributes ‑ test_get_feature_type_raises[123-float128]
howso.utilities.tests.test_features ‑ test_feature_deserialization_number_conversions[data15-float128-original_type15]

♻️ This comment has been updated with latest results.

@apbassett apbassett merged commit 06ed672 into main Nov 5, 2024
40 checks passed
@apbassett apbassett deleted the 21832-more-ifa-uts branch November 5, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants