Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22328: Fixes a bug when doing generative series forecasts using Dataframes for continue_series_values #329

Merged

Conversation

cademack
Copy link
Member

When doing a generative series forecast using react_series and Dataframes as values for continue_series_values, incorrect values were being passed to the howso-engine. Column names were being passed instead of the serialized case values for each series. This fixes the issue.

@cademack cademack requested a review from a team as a code owner November 26, 2024 15:23
@cademack cademack changed the title Fixes a bug when doing generative series forecasts using Dataframes for continue_series_values 22328: Fixes a bug when doing generative series forecasts using Dataframes for continue_series_values Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Test Results

509 tests  ±0   493 ✅ ±0   1m 3s ⏱️ +5s
  1 suites ±0    16 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a031ce7. ± Comparison against base commit f436c0c.

♻️ This comment has been updated with latest results.

@cademack cademack merged commit 8298b85 into main Nov 26, 2024
39 checks passed
@cademack cademack deleted the 22328-fixes-a-bug-when-forecasting-generatively-with-df branch November 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants