-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed app crash when receiving voip push notification in background #174
base: master
Are you sure you want to change the base?
Conversation
Hi @dakenf Maybe this should be removed: |
No, it is being called twice if you add the code from the workaround. It does not seem to cause any side effects (at least we haven't seen any) but i will make changes to check if PKPushRegistry was already created. Will do some testing and update the PR after the Christmas |
Hi @dakenf do you have an update for us already :)? |
@fabriziomoscon @jdegger Hello everyone, sorry for very late reply. Was being busy on other projects. I've updated Twilio SDK to the latest 6.3.0 version, fixed issues with PushKit initialzation that caused crash if code did not respond to VoIP push in time and added info about that to Readme.md Also added a new event for iOS that is triggered when user taps on the call in system call log. It opens the app and sends phone number (or client ID) to js |
Fixed this issue #167
The app is being killed because CallKit was not initialized in time (or not initialized at all for some reason) with JS code. Workaround allows initializing CallKit in obj-c code and handling push notification correctly