Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed app crash when receiving voip push notification in background #174

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dakenf
Copy link
Contributor

@dakenf dakenf commented Dec 14, 2020

Fixed this issue #167
The app is being killed because CallKit was not initialized in time (or not initialized at all for some reason) with JS code. Workaround allows initializing CallKit in obj-c code and handling push notification correctly

@fabriziomoscon
Copy link
Collaborator

Hi @dakenf
are you sure that initPushRegistry will be called once?

Maybe this should be removed:
https://github.com/hoxfon/react-native-twilio-programmable-voice/blob/master/ios/RNTwilioVoice/RNTwilioVoice.m#L71
?

@dakenf
Copy link
Contributor Author

dakenf commented Dec 21, 2020

No, it is being called twice if you add the code from the workaround. It does not seem to cause any side effects (at least we haven't seen any) but i will make changes to check if PKPushRegistry was already created. Will do some testing and update the PR after the Christmas

@jdegger
Copy link
Collaborator

jdegger commented Jan 13, 2021

Hi @dakenf do you have an update for us already :)?

@fabriziomoscon
Copy link
Collaborator

@dakenf is your intention to add any new commit to this?
Anyhow, could I ask to apply this fix to #164 ?

@dakenf
Copy link
Contributor Author

dakenf commented Nov 17, 2021

@fabriziomoscon @jdegger Hello everyone, sorry for very late reply. Was being busy on other projects. I've updated Twilio SDK to the latest 6.3.0 version, fixed issues with PushKit initialzation that caused crash if code did not respond to VoIP push in time and added info about that to Readme.md

Also added a new event for iOS that is triggered when user taps on the call in system call log. It opens the app and sends phone number (or client ID) to js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants