Added unregistration for android #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR(s)! We will test and review them ASAP. |
jdegger
requested changes
Apr 8, 2021
android/src/main/java/com/hoxfon/react/RNTwilioVoice/TwilioVoiceModule.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/hoxfon/react/RNTwilioVoice/TwilioVoiceModule.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/hoxfon/react/RNTwilioVoice/TwilioVoiceModule.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/hoxfon/react/RNTwilioVoice/TwilioVoiceModule.java
Outdated
Show resolved
Hide resolved
| unregisterForCallInvites(); | ||
| WritableMap params = Arguments.createMap(); | ||
| params.putBoolean("initialized", false); | ||
| promise.resolve(params); |
There was a problem hiding this comment.
Wouldn't you want to resolve the promise once onComplete is triggered in unregisterForCallInvites?
There was a problem hiding this comment.
Jesse, you can fix this part, if you think it would be correct (or more accurate), as you know the library in more depth than I am.
…ceModule.java Co-authored-by: Jesse Degger <[email protected]>
…ceModule.java Co-authored-by: Jesse Degger <[email protected]>
…ceModule.java Co-authored-by: Jesse Degger <[email protected]>
…ceModule.java Co-authored-by: Jesse Degger <[email protected]>
|
HI @fabriziomoscon! Could you please specify what do you mean? |
|
Changes included to #205 PR against sdk-5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is addressed to add new feature of unregistration on android device. This feature was tested in our app - now it works correct.
#172 - initial issue, and the same problem occured in our project.