-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for W5500 ethernet module #1231
Conversation
Nice, good job ESP32S3+W5500+NRF ist working now. One more question. |
As before Ethernet >> Wifi. |
I just ordered a PoE Hat for my fusion board. Looking forward to try this PR. |
Oh nice, that means this will be taken care of, as I would need to make the time somehow, even though I have the hardware already... Thanks @AndreasBoehm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected! Nice!
Thanks @Gumbagubanga ❤️ |
There are bittersweet news regarding this PR/feature: I am going to revert these changes in favor of the upstream implementation of the SpiManager and the upstream support for W5500 Ethernet to keep the diff between this project and the upstream to a minimum. I am kind of sorry that we lose this unique selling point. I like to think that @Gumbagubanga's effort added to Thomas motivation to merge tbnobody#2306, which replaces this feature, because earlier Versions of the W5500 support in the upstream project were not merged for a long time. Thanks again to @Gumbagubanga and @marvincarstensen, as this feature was highly appreciated! |
No hard feelings. It's just code and for the time being I can use an old version. :-) |
And time!
Oh no, that is still relevant and valid. The upstream docs should cherry-pick it 😉 Thanks for thinking about that! |
This reverts commit 89d9a40.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Based on the pull-request tbnobody#2068 from the upstream project, I adopted the changes to work with the newly introduced
SPIPortManager
.Credits to @marvincarstensen and @LennartF22 for the implementation of the ETHSPI/W5500 support.