Prepare Release 2024.11.20 #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typo
the configuration write guard is now required when the configuration struct shall be mutated. the write guards locks multiple writers against each other and also, more importantly, makes the writes synchronous to the main loop. all code running in the main loop can now be sure that (1) reads from the configuration struct are non-preemtive and (2) the configuration struct as a whole is in a consistent state when reading from it. NOTE that acquiring a write guard from within the main loop's task will immediately cause a deadlock and the watchdog will trigger a reset. if writing from inside the main loop should ever become necessary, the write guard must be updated to only lock the mutex but not wait for a signal.
SBS CAN receiver implementation was not using the correct way to provide discharge current limit.
This changes the custom current limit so the custom limit is only applied when any of: - SoC is valid and not ignored and SoC < threshold - Voltage is valid and Voltage < threshold - Voltage is invalid Independently, if "Use Battery-Reported limit" is enabled and valid, it is applied (unless a lower custom limit already was applied).
* use wide labels for all battery settings * dynamically show and hide valid battery discharge limit settings
… of magic numbers. This is required to implement further i18n functions using the language packs
the removal of console and debugger statements by esbuild even when not building for production seems to be a regression, as these were definitely working in the past. this change uses the command parameter to configure esbuild to either keep or indeed remove the respective statements. they are only kept if command is not "serve". to avoid having to indent everything in defineConfig() by one block, the return statement and closing curly brace were added "inline".
…1367) use label "Virtual load output state" if LOAD=true and IL=false
on small viewports, the icon and the inverter label would be displayed in two lines. this change keeps the icon and the label tied together in any case, and the icon is centered vertically around the label.
on small viewports, the icon and the inverter label would be displayed in two lines. this change keeps the icon and the label tied together in any case, and the icon is centered vertically around the label.
the removal of console and debugger statements by esbuild even when not building for production seems to be a regression, as these were definitely working in the past. this change uses the command parameter to configure esbuild to either keep or indeed remove the respective statements. they are only kept if command is not "serve". to avoid having to indent everything in defineConfig() by one block, the return statement and closing curly brace were added "inline".
fixes an annoying warning (visible in the browser console): [Vue warn]: Extraneous non-emits event listeners (reload) were passed to component but could not be automatically inherited because component renders fragment or text root nodes. If the listener is intended to be a component custom event listener only, declare it using the "emits" option.
fixes an annoying warning (visible in the browser console): [Vue warn]: Extraneous non-emits event listeners (reload) were passed to component but could not be automatically inherited because component renders fragment or text root nodes. If the listener is intended to be a component custom event listener only, declare it using the "emits" option.
This is required to apply changes which are maybe only related to the data directory.
developed by myself, this feature was now merged from upstream, and the required changes are made to use the config write guard, which enforces synchronized writes to the configuration struct.
if a page uses the reload button, it had only 1 column of space, and only if the viewport was at least "sm". this is not the case for typical smartphones, in which case the reload button would appear on its own row instead of to the right. we now limit the heading to 10 columns if and only if the reload button is to be used, otherwise the heading uses all 12 columns, regardless of the viewport size. the reload buton uses two columns -- if it is displayed at all. the font size of the icon is increased slightly. as the font size of h1 headings changes with the viewport size, we need to center both the heading and the button vertically.
this change allows to support overscaling for all inverters, as the configuration of inputs (which one is part of a particular MPPT) is now provided from withing the code. this information is used to implement overscaling for any of the inverters (which are generally compatible with OpenDTU(-OnBattery)).
order the appearance of inverters in the DPL settings like configured in the list of all inverters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges branch development into master.