Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pav status Regression Test Passing When it Shouldn't #791

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hwikle-lanl
Copy link
Collaborator

This commit fixes an issue in which a recently committed regression test passes even when it shouldn't. The test should now fail if the regression is reintroduced.

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

This commit fixes an issue in which a recently committed regression
test passes even when it shouldn't. The test should now fail if the
regression is reintroduced.
@hwikle-lanl hwikle-lanl self-assigned this Nov 21, 2024
@hwikle-lanl hwikle-lanl changed the title Fix Regression Test Passing When it Shouldn't Fix pav status Regression Test Passing When it Shouldn't Nov 21, 2024
@hwikle-lanl hwikle-lanl requested review from francinelapid and Paul-Ferrell and removed request for francinelapid November 21, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant