-
Notifications
You must be signed in to change notification settings - Fork 20
817 automatically perform module purge before building tests #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hwikle-lanl
wants to merge
17
commits into
develop
Choose a base branch
from
817-automatically-perform-module-purge-before-building-tests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
817 automatically perform module purge before building tests #834
hwikle-lanl
wants to merge
17
commits into
develop
from
817-automatically-perform-module-purge-before-building-tests
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be an option to build/run, but the default should be 'true'. |
1548921
to
227fc75
Compare
078143f
to
0e5e4cb
Compare
I saw that you added a commit that module purges only when modules are specified. It should be always (if enabled), with checks for whether a module system is present (IE - does the |
Paul-Ferrell
requested changes
Apr 28, 2025
ab1517f
to
44ed410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review checklist: