Merge pull request #81 from hpi-swa-teaching/failed-test-comments

Document off-by-one-errors
hpi-swa-teaching · Aug 3, 2022 · 73d4dc5 · 73d4dc5
2 parents a6e6ffe + ba7c3cb
commit 73d4dc5
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 6 deletions.
diff --git a/packages/Tests-SVG-Morphic.package/SVGExportTestCase.class/properties.json b/packages/Tests-SVG-Morphic.package/SVGExportTestCase.class/properties.json
@@ -4,7 +4,7 @@
 		 ],
 	"classvars" : [
 		 ],
-	"commentStamp" : "lra 6/22/2022 16:05",
+	"commentStamp" : "lra 6/23/2022 17:54",
 	"instvars" : [
 		"input",
 		"expected" ],

diff --git a/packages/Tests-SVG-Morphic.package/SVGMorphTest.class/instance/expectedFailures.st b/packages/Tests-SVG-Morphic.package/SVGMorphTest.class/instance/expectedFailures.st
@@ -1,5 +1,5 @@
 testing - printing
 expectedFailures
-
 	"Bounds calculation is broken in the current version, to allow for a CI that tests everything else, these tests have been marked as invalid"
+
 	^ #(#testSVGCircleBounds #testSVGGroup)
diff --git a/packages/Tests-SVG-Morphic.package/SVGMorphTest.class/instance/testSVGCircleBounds.st b/packages/Tests-SVG-Morphic.package/SVGMorphTest.class/instance/testSVGCircleBounds.st
@@ -1,5 +1,6 @@
 testing - properties
 testSVGCircleBounds
+	"Currently, the bounds calculation for circles has an off-by-one-error. Thus, this test is marked as an expected failure."
 
 	|bounds|
 

diff --git a/packages/Tests-SVG-Morphic.package/SVGMorphTest.class/instance/testSVGGroup.st b/packages/Tests-SVG-Morphic.package/SVGMorphTest.class/instance/testSVGGroup.st
@@ -1,5 +1,6 @@
 testing - properties
 testSVGGroup
+	"Currently, the bounds calculation for groups has an off-by-one-error. Thus, this test is marked as an expected failure."
 
 	| bounds morph submorphBounds |
 

diff --git a/packages/Tests-SVG-Morphic.package/SVGMorphTest.class/methodProperties.json b/packages/Tests-SVG-Morphic.package/SVGMorphTest.class/methodProperties.json
@@ -7,7 +7,7 @@
 		"ellipseTestSVGString" : "lra 6/23/2022 19:27",
 		"emptySVGString" : "lra 7/1/2022 18:45",
 		"expectPathSegmentsOf:toEqual:" : "lha 7/21/2022 16:02",
-		"expectedFailures" : "aes 5/29/2022 12:13",
+		"expectedFailures" : "aes 8/3/2022 16:17",
 		"groupTestSVGString" : "lra 6/23/2022 19:27",
 		"lineTestSVGString" : "lra 6/23/2022 19:27",
 		"pathTestSVGString" : "lra 6/23/2022 19:27",
@@ -30,15 +30,15 @@
 		"testDisplayNameOfTSpan" : "aes 5/28/2022 12:14",
 		"testDisplayNameOfText" : "aes 5/28/2022 12:12",
 		"testDisplayNameWithId" : "aes 5/28/2022 12:15",
-		"testSVGCircleBounds" : "lra 6/23/2022 19:29",
+		"testSVGCircleBounds" : "aes 8/3/2022 16:18",
 		"testSVGCircleExists" : "lha 5/22/2022 13:32",
 		"testSVGCircleRectangle" : "lha 5/22/2022 18:41",
 		"testSVGCircleRendering" : "lra 6/23/2022 19:59",
 		"testSVGEllipseBounds" : "lra 6/23/2022 19:29",
 		"testSVGEllipseExists" : "lha 5/22/2022 13:33",
 		"testSVGEllipseRectangle" : "lha 5/22/2022 18:40",
 		"testSVGEllipseRendering" : "lra 6/23/2022 19:59",
-		"testSVGGroup" : "lra 6/23/2022 18:57",
+		"testSVGGroup" : "aes 8/3/2022 16:19",
 		"testSVGGroupExists" : "lha 5/22/2022 13:34",
 		"testSVGLineBounds" : "lra 6/23/2022 19:30",
 		"testSVGLineExists" : "lha 5/22/2022 13:35",

diff --git a/packages/Tests-SVG-Morphic.package/TestSVGBuilder.class/properties.json b/packages/Tests-SVG-Morphic.package/TestSVGBuilder.class/properties.json
@@ -4,7 +4,7 @@
 		 ],
 	"classvars" : [
 		 ],
-	"commentStamp" : "lra 6/22/2022 15:59",
+	"commentStamp" : "lra 6/23/2022 17:39",
 	"instvars" : [
 		 ],
 	"name" : "TestSVGBuilder",