Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libretro: restore requested vulkan api version to match VulkanLoader #19885

Merged

Conversation

warmenhoven
Copy link
Contributor

Changed by #19857 , this breaks loading the ppsspp core on devices where the Vulkan api provided is 1.2 (or lower), particularly Apple devices.

@hrydgard
Copy link
Owner

Why not query it like we do in standalone?

@warmenhoven
Copy link
Contributor Author

Retroarch actually does do vkEnumerateInstanceVersion, and does try to upgrade it if possible. So really the libretro api is expecting the minimum supported version, not the maximum. Actually the libretro docs even say that's the case:

* If app is non-NULL, apiVersion controls the minimum core version required by the application.

app here refers to get_application_info which is a function that returns the VkApplicationInfo, and core is the vulkan core.

@hrydgard hrydgard added this to the v1.19.0 milestone Jan 18, 2025
@hrydgard hrydgard added Vulkan Libretro Issue on Libretro but not all ports. labels Jan 18, 2025
@hrydgard hrydgard merged commit fd36a79 into hrydgard:master Jan 18, 2025
19 checks passed
@warmenhoven warmenhoven deleted the warmenhoven/pr/libretro-vulkan-api branch January 20, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Libretro Issue on Libretro but not all ports. Vulkan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants