Rename and consolidate log functions #19931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould be determined by metadata.
hrydgard
added
the
Code Cleanup
hrydgard
force-pushed
the
rename-log-functions
branch
from
dad5247 to
2af7a04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates HLE logging into fewer, more logical functions. Also, removes the distinction between *LogX and *LogI functions, the type used when logging the return value is now taken from the HLE function metadata.
The next step will be to add a 'e'/'E' (int vs u32) return type that will automatically decode and display error codes as text, but I don't want to include that here to reduce the size of this change.