Rework CalRoutes

hrz-unimr · Jun 2, 2015 · 7f39020 · 7f39020
1 parent 8313b6b
commit 7f39020
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 40 deletions.
diff --git a/...ent/UserInterfaceHook/REST/RESTController/extensions/calendar_v1/models/CalendarModel.php b/...ent/UserInterfaceHook/REST/RESTController/extensions/calendar_v1/models/CalendarModel.php
@@ -102,9 +102,9 @@ function getCalUpcomingEvents($user_id)
 
             // see permalink code at ilCalendearAppointmentGUI l.804 (showInfoScreen())
             include_once('./Services/Calendar/classes/class.ilCalendarCategoryAssignments.php');
-            $cat_id = ilCalendarCategoryAssignments::_lookupCategory($entry->getEntryId());
-            $cat_info = ilCalendarCategories::_getInstance()->getCategoryInfo($cat_id);
-            $refs = ilObject::_getAllReferences($cat_info['obj_id']);
+            $cat_id = \ilCalendarCategoryAssignments::_lookupCategory($entry->getEntryId());
+            $cat_info = \ilCalendarCategories::_getInstance()->getCategoryInfo($cat_id);
+            $refs = \ilObject::_getAllReferences($cat_info['obj_id']);
             $tmp_arr['reference'] = current($refs); // reference id
             $appointments[] = $tmp_arr;
         }

diff --git a/...nt/UserInterfaceHook/REST/RESTController/extensions/calendar_v1/routes/CalendarRoutes.php b/...nt/UserInterfaceHook/REST/RESTController/extensions/calendar_v1/routes/CalendarRoutes.php
@@ -2,7 +2,7 @@
 /**
  * ILIAS REST Plugin for the ILIAS LMS
  *
- * Authors: D.Schaefer and T. Hufschmidt <(schaefer|hufschmidt)@hrz.uni-marburg.de>
+ * Authors: D.Schaefer and T.Hufschmidt <(schaefer|hufschmidt)@hrz.uni-marburg.de>
  * 2014-2015
  */
 namespace RESTController\extensions\calendar_v1;
@@ -23,15 +23,9 @@
         $authorizedUserId = $accessToken->getUserId();
 
         if ($authorizedUserId == $id || Libs\RESTLib::isAdminByUserId($authorizedUserId)) { // only the user or the admin is allowed to access the data
-            try {
-                $model = new CalendarModel();
-                $data = $model->getCalUpcomingEvents($id);
-
-                $app->success($data);
-            }
-            catch (\Exception $e) {
-                $app->halt(500, 'Error: Could not retrieve any events for user '.$id.".", -15);
-            }
+            $model = new CalendarModel();
+            $data = $model->getCalUpcomingEvents($id);
+            $app->success($data);
         }
         else
             $app->halt(401, Libs\RESTLib::MSG_NO_ADMIN, Libs\RESTLib::ID_NO_ADMIN);
@@ -48,15 +42,10 @@
         $authorizedUserId = $accessToken->getUserId();
 
         if ($authorizedUserId == $id || Libs\RESTLib::isAdminByUserId($authorizedUserId)) { // only the user or the admin is allowed to access the data
-            try {
-                $model = new CalendarModel();
-                $data = $model->getIcalAdress($id);
-
-                $app->success($data);
-            }
-            catch (\Exception $e) {
-                $app->halt(500, 'Error: Could not retrieve ICAL url for user '.$id.".", -15);
-            }
+            $model = new CalendarModel();
+            $data = $model->getIcalAdress($id);
+
+            $app->success($data);
         }
         else
             $app->halt(401, Libs\RESTLib::MSG_NO_ADMIN, Libs\RESTLib::ID_NO_ADMIN);
@@ -74,15 +63,10 @@
 
         if ($authorizedUserId > -1) { // only the user is allowed to access the data
             $id = $authorizedUserId;
-            try {
-                $model = new CalendarModel();
-                $data = $model->getCalUpcomingEvents($id);
-
-                $app->success($data);
-            }
-            catch (\Exception $e) {
-                $app->halt(500, 'Error: Could not retrieve any events for user '.$id.".", -15);
-            }
+            $model = new CalendarModel();
+            $data = $model->getCalUpcomingEvents($id);
+
+            $app->success($data);
         }
         else
             $app->halt(401, Libs\RESTLib::MSG_NO_ADMIN, Libs\RESTLib::ID_NO_ADMIN);
@@ -100,15 +84,10 @@
 
         if ($authorizedUserId > -1 ) { // only the user or the admin is allowed to access the data
             $id = $authorizedUserId;
-            try {
-                $model = new CalendarModel();
-                $data = $model->getIcalAdress($id);
-
-                $app->success($data);
-            }
-            catch (\Exception $e) {
-                $app->halt(500, 'Error: Could not retrieve ICAL url for user '.$id.".", -15);
-            }
+            $model = new CalendarModel();
+            $data = $model->getIcalAdress($id);
+
+            $app->success($data);
         }
         else
             $app->halt(401, Libs\RESTLib::MSG_NO_ADMIN, Libs\RESTLib::ID_NO_ADMIN);