Adds missing {} to else and fixes a cosmetic issue #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing, then re-opening in order to trigger CI. |
|
@hoijui, thanks for the contribution. The change looks straightforward and the regression tests pass on all platforms. However there's an internal API change causing the API test to fail. I'll try to dig into it eventually, but if you have any insight, that would be appreciated. |
|
uff.. had a look at it, but could not see why it would fail. :/ ... ouh, should I maybe just rebase on current HEAD? |
|
I'll have a look at it sometime this weekend. It's possible that the API test isn't robust, and is at fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found through compiler-warnings