Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Scala Collection Compat #668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

etspaceman
Copy link

Currently, providing the CollectionConverters object manually in the scala.jdk package as a part of Rho causes assembly issues, as projects with dependencies on Rho and the Scala Collection Compat will require conflicts to be resolved.

From what I understand, this was originally done to avoid bincompat issues during updates, as the collection compat library broke some rules early on. This has gotten a lot more stable and is pretty widely used now in the Scala ecosystem, so it seems much safer to include this library.

Another option could be to repackage the collection converters under a new namespace. I could work on that if that is preferred.

@etspaceman
Copy link
Author

Solves #669

@etspaceman
Copy link
Author

Looks like this fails mima so we would have to be OK breaking binary compat for this kind of change. It seems pretty darn harmless though, considering the file that is being removed is replaced by a transitive dependency in the same package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant