Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, providing the CollectionConverters object manually in the
scala.jdk
package as a part of Rho causes assembly issues, as projects with dependencies on Rho and the Scala Collection Compat will require conflicts to be resolved.From what I understand, this was originally done to avoid bincompat issues during updates, as the collection compat library broke some rules early on. This has gotten a lot more stable and is pretty widely used now in the Scala ecosystem, so it seems much safer to include this library.
Another option could be to repackage the collection converters under a new namespace. I could work on that if that is preferred.