Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InputStore and Enhance Template Renderer with Input Support #14

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

httpdss
Copy link
Owner

@httpdss httpdss commented Sep 25, 2024

Overview:
This PR introduces several changes, primarily aimed at improving input management during template generation and adding test coverage enhancements.

Changes:

  • Added a new InputStore class to manage input data storage in JSON format.
  • Updated the TemplateRenderer class to integrate with InputStore for loading and saving user inputs.
  • Enhanced the generate.py module by adding the --input-store argument, enabling users to specify a file path for input storage.
  • Refined argument handling in generate.py and improved the file creation process with the new input_store field.
  • Minor changes to the FileItem class to support input_store integration.
  • Added pytest-cov to the requirements.dev.txt for improved test coverage.

Justification:
These updates are part of an effort to streamline the input handling process for the structure generation tool. By using InputStore, the system can persistently manage user-provided inputs across sessions, reducing redundant data entry. Additionally, the integration with TemplateRenderer allows for smoother processing of template variables.

Impact:

  • Enhanced user experience by minimizing repetitive input prompts.
  • Improved maintainability and flexibility in handling structured data.
  • Additional test coverage through the inclusion of pytest-cov.

@httpdss httpdss changed the title wip Add InputStore and Enhance Template Renderer with Input Support Sep 25, 2024
@httpdss httpdss marked this pull request as ready for review September 25, 2024 23:48
@httpdss httpdss merged commit 646a2dd into main Sep 25, 2024
3 checks passed
@httpdss httpdss deleted the inputstore branch September 25, 2024 23:48
@httpdss httpdss self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant