Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure support for Python 3.11/3.12 #1540

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Nov 19, 2023

Hello @jkbrzt,

Thank you for this awesome tool! πŸ™‡πŸ»β€β™‚οΈ

I believe it would be nice to have supported Python versions listed explicitly, so I'd like to suggest changes that:

  • enable testing for Python 3.11/3.12 on CI
  • update classifiers at setup.py

Best regards!

These changes:
  * enable testing for Python 3.11/3.12 on CI
  * update classifiers at setup.py
@codecov-commenter
Copy link

Codecov Report

Attention: 315 lines in your changes are missing coverage. Please review.

Comparison is base (4d7d6b6) 97.28% compared to head (946ad3a) 94.26%.
Report is 360 commits behind head on master.

Files Patch % Lines
httpie/output/ui/rich_help.py 52.88% 49 Missing ⚠️
httpie/compat.py 36.73% 31 Missing ⚠️
httpie/manager/tasks/plugins.py 79.73% 31 Missing ⚠️
httpie/internal/daemons.py 48.27% 30 Missing ⚠️
httpie/output/ui/rich_utils.py 0.00% 18 Missing ⚠️
httpie/output/ui/man_pages.py 0.00% 16 Missing ⚠️
httpie/output/ui/rich_progress.py 75.80% 15 Missing ⚠️
httpie/manager/compat.py 62.85% 13 Missing ⚠️
httpie/cli/argparser.py 89.02% 9 Missing ⚠️
httpie/output/ui/palette.py 87.50% 9 Missing ⚠️
... and 32 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1540      +/-   ##
==========================================
- Coverage   97.28%   94.26%   -3.02%     
==========================================
  Files          67      113      +46     
  Lines        4235     7695    +3460     
==========================================
+ Hits         4120     7254    +3134     
- Misses        115      441     +326     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@jkbrzt jkbrzt merged commit 8ac44b5 into httpie:master Mar 4, 2024
37 of 38 checks passed
@jkbrzt
Copy link
Member

jkbrzt commented Mar 4, 2024

Thanks, @Jamim!

@Jamim Jamim deleted the feature/python-support branch March 7, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants