Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC6265bis: Offload Service Worker SFC computation to spec #2217

Merged
merged 6 commits into from
Jul 27, 2022

Conversation

sbingler
Copy link
Collaborator

@sbingler sbingler commented Jul 7, 2022

Closes #1288

This changes how 6265bis computes the Site for Cookies for Service Workers by referring to their spec instead of spelling it out locally.

It's been some time since this was last discussed so while I think this was the agreed upon change I may be mistaken.

This changes how 6265bis computes the Site for Cookies for
Service Workers by referring to their spec instead of spelling
it out locally.
@sbingler sbingler changed the title RFC6265bis: Offload Service Worker SFC computation to spe RFC6265bis: Offload Service Worker SFC computation to spec Jul 8, 2022
@sbingler
Copy link
Collaborator Author

@mikewest ping

Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable from the perspective of the cookies spec, but I don't think the service worker spec actually says anything explicitly about this topic. Is there a PR underway, or did I miss the explanation?

@sbingler
Copy link
Collaborator Author

@wanderview has a filed some issues tracking the work here w3c/ServiceWorker#1604 (reference)

sbingler added 3 commits July 14, 2022 16:51
This changes how 6265bis computes the Site for Cookies for
Service Workers by referring to their spec instead of spelling
it out locally.
@wanderview
Copy link

Can you file a new issue on the service worker spec to add a section discussing SFC computation?

@sbingler
Copy link
Collaborator Author

@mikewest
How does the tracking issue suit you?

@sbingler
Copy link
Collaborator Author

@mikewest ping

@mikewest
Copy link
Member

Hi, sorry. I've been a potato for the recent past, slowly recovering from covid. I'm happy to land this with the issue filed.

@mikewest mikewest merged commit 756f17c into httpwg:main Jul 27, 2022
@sbingler sbingler deleted the Issue1288 branch September 9, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"Site for cookies" handling for service workers
3 participants