Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for releasing this great codebase! I moved the main python scripts into a
crown_ibp
directory to make them part of a python package, which allows other packages to easily import these useful methods/classes. You can now install this package with pip (because of the newsetup.py
) and thus run the scripts from other directories without having to change path variables. I also updated the README to reflect that you can call the train and eval scripts from other places after installing the package, but the config file paths still need to be dealt with.No need to accept this pull request if you have different preferences for organizing the repo -- I can keep this fork open.