Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pip install-able pkg #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

mfe7
Copy link

@mfe7 mfe7 commented May 4, 2020

Thanks for releasing this great codebase! I moved the main python scripts into a crown_ibp directory to make them part of a python package, which allows other packages to easily import these useful methods/classes. You can now install this package with pip (because of the new setup.py) and thus run the scripts from other directories without having to change path variables. I also updated the README to reflect that you can call the train and eval scripts from other places after installing the package, but the config file paths still need to be dealt with.

No need to accept this pull request if you have different preferences for organizing the repo -- I can keep this fork open.

@huanzhang12
Copy link
Owner

@mfe7 Thank you for this great contribution! This is a very nice change that I always want to do but did not get a chance to make it. I will review your pull request and merge it.

BTW we have released a new paper which generalizes CROWN to a general computational graph algorithm. Our new implementation, the auto_LiRPA library, allows you to compute bounds for any computational graph defined by PyTorch without any manual derivations, just like how easily you can obtain gradients in PyTorch. It should be much easier to use for any new projects. 🙂

@mfe7
Copy link
Author

mfe7 commented May 8, 2020

Cool! I'll take a look! Thanks for sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants