Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdn/cache_url_tasks): refactor the cache_url_tasks data source code style #6155

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Jan 7, 2025

What this PR does / why we need it:

refactor the cache_url_tasks data source code style

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


refactor the `cache_url_tasks` data source code style

PR Checklist

  • Tests added/passed.
$ export HW_CDN_DOMAIN_URL=xxxxxxxxxx
$ make testacc TEST="./huaweicloud/services/acceptance/cdn" TESTARGS="-run TestAccDataSourceCacheUrlTasks_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cdn -v -run TestAccDataSourceCacheUrlTasks_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCacheUrlTasks_basic
=== PAUSE TestAccDataSourceCacheUrlTasks_basic
=== CONT  TestAccDataSourceCacheUrlTasks_basic
--- PASS: TestAccDataSourceCacheUrlTasks_basic (11.83s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cdn       11.869s

Test case coverage

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@jinyangyang222 jinyangyang222 force-pushed the refactor-cdn/refactor-cache_url_tasks-codeStyle branch from fdf4d9a to 32616f1 Compare January 7, 2025 07:27
@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 7, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit c2be21c into huaweicloud:master Jan 7, 2025
14 checks passed
@jinyangyang222 jinyangyang222 deleted the refactor-cdn/refactor-cache_url_tasks-codeStyle branch January 15, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants