Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fgs/dependency): using auto-gen style to replace old coding #6265

Conversation

Lance52259
Copy link
Contributor

@Lance52259 Lance52259 commented Jan 27, 2025

What this PR does / why we need it:
Using auto-generate style to replace the old resource coding.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. using auto-gen style to replace old coding.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o fgs -f TestAccDependencyVersion_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/fgs" -v -coverprofile="./huaweicloud/services/acceptance/fgs/fgs_coverage.cov" -coverpkg="./huaweicloud/services/fgs" -run TestAccDependencyVersion_basic -timeout 360m -parallel 10
=== RUN   TestAccDependencyVersion_basic
=== PAUSE TestAccDependencyVersion_basic
=== CONT  TestAccDependencyVersion_basic
--- PASS: TestAccDependencyVersion_basic (38.98s)
PASS
coverage: 10.4% of statements in ./huaweicloud/services/fgs
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/fgs       39.030s coverage: 10.4% of statements in ./huaweicloud/services/fgs
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_fgs_dependencies_version_refactor branch 2 times, most recently from 09e86b2 to b6b4463 Compare January 27, 2025 08:13
@Lance52259 Lance52259 force-pushed the br_fgs_dependencies_version_refactor branch from b6b4463 to 1a05ec4 Compare February 10, 2025 03:44
@github-actions github-actions bot added size/L and removed size/M labels Feb 10, 2025
@Lance52259 Lance52259 force-pushed the br_fgs_dependencies_version_refactor branch 3 times, most recently from 480a944 to 5e7732f Compare February 10, 2025 06:36
@Lance52259
Copy link
Contributor Author

./scripts/coverage.sh -o fgs -f TestAccDependencyVersion_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/fgs" -v -coverprofile="./huaweicloud/services/acceptance/fgs/fgs_coverage.cov" -coverpkg="./huaweicloud/services/fgs" -run TestAccDependencyVersion_basic -timeout 360m -parallel 10
=== RUN   TestAccDependencyVersion_basic
=== PAUSE TestAccDependencyVersion_basic
=== CONT  TestAccDependencyVersion_basic
--- PASS: TestAccDependencyVersion_basic (14.30s)
PASS
coverage: 10.5% of statements in ./huaweicloud/services/fgs
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/fgs       14.346s coverage: 10.5% of statements in ./huaweicloud/services/fgs

@Lance52259 Lance52259 force-pushed the br_fgs_dependencies_version_refactor branch 2 times, most recently from 90d49fb to 49fa990 Compare February 11, 2025 01:51
@Lance52259 Lance52259 force-pushed the br_fgs_dependencies_version_refactor branch from 49fa990 to d50422e Compare February 11, 2025 03:32
@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Feb 13, 2025
@github-ci-robot github-ci-robot merged commit 8ea321b into huaweicloud:master Feb 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants