Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send order hash during failed match validations #130

Merged
merged 4 commits into from
Oct 4, 2023
Merged

send order hash during failed match validations #130

merged 4 commits into from
Oct 4, 2023

Conversation

atvanguard
Copy link

@atvanguard atvanguard commented Oct 4, 2023 •
edited
Loading

So that the reason can be printed in EVM and OrderMatchingError can be searched by indexed field orderHash

@atvanguard atvanguard changed the title send order hash during match validations send order hash during failed match validations Oct 4, 2023
@atvanguard atvanguard merged commit 3cf0921 into main Oct 4, 2023
3 checks passed
@atvanguard atvanguard deleted the order-hash branch October 4, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumos42 lumos42 lumos42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atvanguard @lumos42